Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41484 )
Change subject: Documentation/mainboard/lenovo/t420s.md: Add documentation for Lenovo T420s ......................................................................
Patch Set 1:
(6 comments)
Welcome!
https://review.coreboot.org/c/coreboot/+/41484/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/41484/1//COMMIT_MSG@7 PS1, Line 7: mainboard mb
https://review.coreboot.org/c/coreboot/+/41484/1//COMMIT_MSG@7 PS1, Line 7: Documentation Doc
https://review.coreboot.org/c/coreboot/+/41484/1/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t420s.md:
https://review.coreboot.org/c/coreboot/+/41484/1/Documentation/mainboard/len... PS1, Line 5: magnesum magnes*i*um
https://review.coreboot.org/c/coreboot/+/41484/1/Documentation/mainboard/len... PS1, Line 8: Below is a picture of IC on the mainboard with clip attached, and a picture of the Raspberry Pi with cables attached. In this case it's a Winbond flash chip "W25Q64.V". Split this line in two?
https://review.coreboot.org/c/coreboot/+/41484/1/Documentation/mainboard/len... PS1, Line 12: Two empty lines
https://review.coreboot.org/c/coreboot/+/41484/1/Documentation/mainboard/len... File Documentation/mainboard/lenovo/t420s_board.jpg:
PS1: These images are quite large. Maybe crop them and use some tool to make them smaller? Ideally, something under 50 KiB would be desired.