Rishabh Sharma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33425 )
Change subject: qcs405: Add support for specifying mbn_version ......................................................................
Patch Set 4:
(5 comments)
https://review.coreboot.org/#/c/33425/4/util/qualcomm/createxbl.py File util/qualcomm/createxbl.py:
https://review.coreboot.org/#/c/33425/4/util/qualcomm/createxbl.py@214 PS4, Line 214: None
Didn't we agree this should be 3 if it is not set to anything else?
Yes default can be 3. I am agree with this.
https://review.coreboot.org/#/c/33425/4/util/qualcomm/createxbl.py@217 PS4, Line 217: is_ext_mbn_v5 = True
Again, you should remove this variable because header_version == 5 already means the same thing.
Done
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py File util/qualcomm/mbn_tools.py:
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py@1010 PS4, Line 1010: #
Please align comment correctly
Done
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py@1018 PS4, Line 1018: =0
spacing
Done
https://review.coreboot.org/#/c/33425/4/util/qualcomm/mbn_tools.py@1058 PS4, Line 1058: if (sha_algo is 'SHA384'):
Please use == for string comparison
Done