[coreboot-gerrit] Change in coreboot[master]: soc/intel/apollolake: Code clean up by using common PCR module

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/18673 )

Change subject: soc/intel/apollolake: Code clean up by using common PCR module
......................................................................

Patch Set 7:

(3 comments)

https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/bootblock/b...
File src/soc/intel/apollolake/bootblock/bootblock.c:

PS7, Line 50: pcr_read32(PID_RTC, R_PCH_PCR_RTC_CONF, &reg);
            : 	reg |= B_PCH_PCR_RTC_CONF_UCMOS_EN;
            : 	pcr_write32(PID_RTC, R_PCH_PCR_RTC_CONF, reg);
why not use pcr_and_then_or?

https://review.coreboot.org/#/c/18673/7/src/soc/intel/apollolake/gpio.c
File src/soc/intel/apollolake/gpio.c:

PS7, Line 123: pcr_read32(port, hostsw_reg, &val);
             : 	val |= 1 << (pin % 32);
             : 	pcr_write32(port, hostsw_reg, val);
pcr_and_then_or?

PS7, Line 147: pcr_read32(port, en_reg, &value);
             : 	value |= 1 << (pin % GPIO_MAX_NUM_PER_GROUP);
             : 	pcr_write32(port, en_reg , value);
pcr_and_then_or