Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41992 )
Change subject: [WIP] sb/intel: Always raise SMI with APM_CNT_FINALIZE
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/smihandler.c:
https://review.coreboot.org/c/coreboot/+/41992/2/src/southbridge/intel/bd82x...
PS2, Line 214: return;
Ahh.. I did not realize payload has to do this via SMI. […]
Ok.. Can we do something like this instead?
static int once;
if (!once) {
once++;
if (!CONFIG(INTEL_CHIPSET_LOCKDOWN))
return;
}
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41992
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b6450e0c8436e1c6113d54b7987b6b486908ed9
Gerrit-Change-Number: 41992
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 08 Jun 2020 13:47:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment