Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39612 )
Change subject: sc7180: clock: Add display external clock in coreboot ......................................................................
Patch Set 29: Code-Review+2
(7 comments)
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/cl... File src/soc/qualcomm/sc7180/clock.c:
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/cl... PS27, Line 342: divider
Okay, if this parameter is actually 2x to divide by x, then let's call it half_divider or something […]
Done
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/cl... PS27, Line 371: {
Can't you just call clock_configure_mnd() here?
Done
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/cl... PS27, Line 377: m
n?
Ack
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/in... File src/soc/qualcomm/sc7180/include/soc/clock.h:
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/in... PS27, Line 133: struct sc7180_mdss_rcg {
No longer needed.
Done
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/in... PS27, Line 147: pclk0_rcgr
This is the whole clock structure now, not just the RCGR, so shouldn't it just be called `pclk0` (sa […]
Done
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/in... PS27, Line 305: uint32_t
enum mdss_clock
Done
https://review.coreboot.org/c/coreboot/+/39612/27/src/soc/qualcomm/sc7180/in... PS27, Line 307: uint32_t
ditto
Done