Patch set 29:Code-Review +2
7 comments:
File src/soc/qualcomm/sc7180/clock.c:
Patch Set #27, Line 342: divider
Okay, if this parameter is actually 2x to divide by x, then let's call it half_divider or something […]
Done
Can't you just call clock_configure_mnd() here?
Done
n?
Ack
File src/soc/qualcomm/sc7180/include/soc/clock.h:
Patch Set #27, Line 133: struct sc7180_mdss_rcg {
No longer needed.
Done
Patch Set #27, Line 147: pclk0_rcgr
This is the whole clock structure now, not just the RCGR, so shouldn't it just be called `pclk0` (sa […]
Done
Patch Set #27, Line 305: uint32_t
enum mdss_clock
Done
Patch Set #27, Line 307: uint32_t
ditto
Done
To view, visit change 39612. To unsubscribe, or for help writing mail filters, visit settings.