[coreboot-gerrit] Change in coreboot[master]: soc/intel: Add Skylake-SP and Cascade Lake support

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35126 )

Change subject: soc/intel: Add Skylake-SP and Cascade Lake support
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35126/7//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/35126/7//COMMIT_MSG@7 
PS7, Line 7: Add Skylake-SP
> I think the Supermicro board you mentioned on other changes has BootGuard enabled, not sure about th […]

IMO, no matter what Intel does about FSP, integrating Skylake SP support
should come after a huge restructuring of the whole soc/intel/ code. With
such a platform, having the code in soc/ makes even less sense that it
makes for the smaller PCH-H platforms now.

Please don't waste time with half-baked patches before there is a bigger
plan to integrate this platform. The only thing we can achive atm, is
even more congestion in this area.