Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37178 )
Change subject: soc/amd/common/block/acpimmio: fix ACPIMMIO decode enable function
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in...
File src/soc/amd/common/block/include/amdblocks/acpimmio_map.h:
https://review.coreboot.org/c/coreboot/+/37178/5/src/soc/amd/common/block/in...
PS5, Line 26: * enable the decode in PMx24 instead. All discrete FCHs and the Kabini
See latest CB:37401 comments
Ohh right... Did not grep enough and have lacking knowledge in platforms codenames. Anyway, the change do not break anything at its current state. Will apply a conditional definitions for the discrete FCH's
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37178
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa31abc3dbdf77d8513fa83c7415b9a1b7fd266f
Gerrit-Change-Number: 37178
Gerrit-PatchSet: 6
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 02 Dec 2019 10:18:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-MessageType: comment