[coreboot-gerrit] [M] Change in coreboot[master]: mb/google/nissa/var/craaskov: Add overridetree

[Derek Huang (Code Review)]

Attention is currently required from: Chen-Tsung Hsieh, Dtrain Hsu, Ian Feng, Kenny Pan, Rex Chou, Shou-Chieh Hsu, Subrata Banik, Sumeet R Pawnikar, Tarun Tuli.

Derek Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76662?usp=email )

Change subject: mb/google/nissa/var/craaskov: Add overridetree
......................................................................

Patch Set 9:

(17 comments)

File src/mainboard/google/brya/variants/craaskov/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/76662/comment/068cf66b_48f8d16e :
PS9, Line 79:                 device ref i2c1 on
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/176ed105_87a230c3 :
PS9, Line 81:                                 register "generic.hid" = ""ELAN9004""
            :                                 register "generic.desc" = ""ELAN Touchscreen""
            :                                 register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_C7_IRQ)"
            :                                 register "generic.probed" = "1"
            :                                 register "generic.reset_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C1)"
            :                                 register "generic.reset_delay_ms" = "20"
            :                                 register "generic.reset_off_delay_ms" = "2"
            :                                 register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C0)"
            :                                 register "generic.enable_delay_ms" = "1"
            :                                 register "generic.stop_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_LOW(GPP_C6)"
            :                                 register "generic.stop_delay_ms" = "150"
            :                                 register "generic.stop_off_delay_ms" = "2"
            :                                 register "generic.has_power_resource" = "1"
            :                                 register "hid_desc_reg_offset" = "0x01"
            :                                 device i2c 10 on end
use tab

https://review.coreboot.org/c/coreboot/+/76662/comment/a3feb6e7_929c5050 :
PS9, Line 98:                 
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/62b3bcb7_dc4ebaf4 :
PS9, Line 110:                 
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/b2a768c3_6fa5dcea :
PS9, Line 111:                 
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/2c33e47c_3807d8e5 :
PS9, Line 131:                 
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/03d10abb_84f80001 :
PS9, Line 176:                                                 register "use_custom_pld" = "true"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/04baeacc_15d90d62 :
PS9, Line 177:                                                 register "custom_pld" = "ACPI_PLD_TYPE_C(LEFT, LEFT, ACPI_PLD_GROUP(1, 1))"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/2ddabd99_4ab93aae :
PS9, Line 183:                                                 register "use_custom_pld" = "true"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/a028da3a_8fc40369 :
PS9, Line 184:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/d5de1513_6bb68323 :
PS9, Line 190:                                                 register "use_custom_pld" = "true"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/e15180f5_b27a0408 :
PS9, Line 191:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/266d5783_1fd6b5ee :
PS9, Line 206:                                         chip drivers/usb/acpi
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/3b79a490_0d700686 :
PS9, Line 215:                                                 register "use_custom_pld" = "true"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/0b1f0817_feccb66a :
PS9, Line 216:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(LEFT, RIGHT, ACPI_PLD_GROUP(3, 1))"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/5812c05b_4aa94130 :
PS9, Line 222:                                                 register "use_custom_pld" = "true"
tab

https://review.coreboot.org/c/coreboot/+/76662/comment/425a60ac_ff1a166f :
PS9, Line 223:                                                 register "custom_pld" = "ACPI_PLD_TYPE_A(RIGHT, LEFT, ACPI_PLD_GROUP(4, 1))"
tab