Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40379 )
Change subject: soc/intel: Update SA common code based on CONFIG_PCI_SEGMENT_GROUPS ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40379/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/Kconfig:
https://review.coreboot.org/c/coreboot/+/40379/2/src/soc/intel/common/block/... PS2, Line 12: config SA_PCIEX_LENGTH : hex : default 0x10000000 if (PCIEX_LENGTH_256MB) : default 0x8000000 if (PCIEX_LENGTH_128MB) : default 0x4000000 if (PCIEX_LENGTH_64MB) : default 0x10000000 : help : This option allows you to select length of PCIEX region.
Should this not be a Kconfig option any longer then?
yes, i think choice might not be the right strategy here because it block freedom from SOC to select the right PCIEX length. like i might wish to select PCIEX_LENGTH_512MB from SoC code then choice won't allow that?