Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32346 )
Change subject: [WIP]mb/fujitsu: add Esprimo E900 ......................................................................
Patch Set 8: Code-Review+1
(5 comments)
I would focus on the SuperIO now.
https://review.coreboot.org/#/c/32346/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32346/8//COMMIT_MSG@17 PS8, Line 17: Graphics Nice! Is this the iGPU, a PCIe dGPU or both?
If using the iGPU, which ports are tested?
https://review.coreboot.org/#/c/32346/8//COMMIT_MSG@22 PS8, Line 22: You may want to extend the two previous sections and specify what is not tested.
https://review.coreboot.org/#/c/32346/8/src/mainboard/fujitsu/esprimo_e900/d... File src/mainboard/fujitsu/esprimo_e900/devicetree.cb:
https://review.coreboot.org/#/c/32346/8/src/mainboard/fujitsu/esprimo_e900/d... PS8, Line 39: device pci 1c.0 on end # PCIe Port #1 : device pci 1c.1 on end # PCIe Port #2 : device pci 1c.2 on end # PCIe Port #3 : device pci 1c.3 on end # PCIe Port #4 : device pci 1c.4 on end # PCIe Port #5 : device pci 1c.5 on end # PCIe Port #6 : device pci 1c.6 on end # PCIe Port #7 : device pci 1c.7 on end # PCIe Port #8 If you can, please use lspci to identify what these are connected to.
https://review.coreboot.org/#/c/32346/8/src/mainboard/fujitsu/esprimo_e900/d... PS8, Line 48: device pci 1e.0 on end # PCI bridge This should be the PCI port the board has (if it has any), does it work?
https://review.coreboot.org/#/c/32346/8/src/mainboard/fujitsu/esprimo_e900/g... File src/mainboard/fujitsu/esprimo_e900/gma-mainboard.ads:
https://review.coreboot.org/#/c/32346/8/src/mainboard/fujitsu/esprimo_e900/g... PS8, Line 22: DVI-I I see there's a DisplayPort connector, maybe you want to enable DP1, DP2 and DP3 just in case.
Also, since DVI-I has both DVI and VGA, you would want to enable Analog as well.