Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44355 )
Change subject: soc/intel/tigerlake: Allow fine grained control of S0iX states ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44355/1/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.h:
https://review.coreboot.org/c/coreboot/+/44355/1/src/soc/intel/tigerlake/chi... PS1, Line 82:
I would like this to default to 0xFF for any board that does not mention this setting in their devic […]
If you are open to introducing a new element "LpmStateEnable", then its default value of '0' (when not configured in devicetree) can be used to assign a default value of 0xff to the LpmStateEnableMask. Otherwise, assign the value configured in the devicetree.