Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31461 )
Change subject: intel/apollolake: Add smbus defines
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/31461/3/src/soc/intel/apollolake/include/soc...
File src/soc/intel/apollolake/include/soc/smbus.h:
https://review.coreboot.org/#/c/31461/3/src/soc/intel/apollolake/include/soc...
PS3, Line 20: #define SMB_RCV_SLVA 0x09
Please use tabs for alignment as below.
https://review.coreboot.org/#/c/31461/3/src/soc/intel/apollolake/include/soc...
PS3, Line 32: #define SMBUS_SLAVE_ADDR 0x24
As above.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31461
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic472c71998064d09c9caddc5c80c01e85a381c69
Gerrit-Change-Number: 31461
Gerrit-PatchSet: 3
Gerrit-Owner: Christian Gmeiner
christian.gmeiner@gmail.com
Gerrit-Reviewer: Christian Gmeiner
christian.gmeiner@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Comment-Date: Thu, 21 Mar 2019 10:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment