Richard Spiegel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35667 )
Change subject: util/amdfwtool: Grow the Embedded Firmware Structure
......................................................................
Patch Set 2:
(1 comment)
Doing some review while I have nothing to do.
https://review.coreboot.org/c/coreboot/+/35667/2/util/amdfwtool/amdfwtool.c
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/35667/2/util/amdfwtool/amdfwtool.c@...
PS2, Line 391: 0x4f
Why so much reserved? Is there expectation to fill it up? If not, would it not be preferable 0x3f, making total size 0x40 (power of 2)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35667
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I098ffc7c05d27387a877e6b7c8628d98939bd9af
Gerrit-Change-Number: 35667
Gerrit-PatchSet: 2
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@amd.corp-partner.google.com
Gerrit-Reviewer: Justin Frodsham
justin.frodsham@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Oct 2019 00:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment