build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39848 )
Change subject: mb/google/deltaur: Update onboard memory config ......................................................................
Patch Set 19:
(31 comments)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/baseboard/include/baseboard/variants.h:
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 27: void __weak variant_memory_init(FSP_M_CONFIG *mem_cfg); Using weak declarations can have unintended link defects
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... File src/mainboard/google/deltaur/variants/deltan/memory.c:
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 21: { 15, 8, 11, 13, 10, 12, 14, 9, }, /* Byte 2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 21: { 15, 8, 11, 13, 10, 12, 14, 9, }, /* Byte 2 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 23: { 7, 2, 6, 3, 4, 0, 5, 1, }, /* Byte 4 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 23: { 7, 2, 6, 3, 4, 0, 5, 1, }, /* Byte 4 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 24: { 14, 10, 15, 11, 9, 13, 8, 12, }, /* Byte 5 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 24: { 14, 10, 15, 11, 9, 13, 8, 12, }, /* Byte 5 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 25: { 8, 10, 14, 12, 9, 13, 11, 15, }, /* Byte 6 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 25: { 8, 10, 14, 12, 9, 13, 11, 15, }, /* Byte 6 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 26: { 2, 7, 4, 5, 1, 3, 0, 6 }, /* Byte 7 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 26: { 2, 7, 4, 5, 1, 3, 0, 6 }, /* Byte 7 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 31: { 0, 6, 2, 7, 3, 5, 1, 4, }, /* Byte 1 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 31: { 0, 6, 2, 7, 3, 5, 1, 4, }, /* Byte 1 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 32: { 10, 9, 14, 12, 11, 8, 15, 13, }, /* Byte 2 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 32: { 10, 9, 14, 12, 11, 8, 15, 13, }, /* Byte 2 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 33: { 7, 3, 1, 4, 6, 2, 0, 5, }, /* Byte 3 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 33: { 7, 3, 1, 4, 6, 2, 0, 5, }, /* Byte 3 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 34: { 10, 9, 13, 12, 8, 14, 11, 15, }, /* Byte 4 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 34: { 10, 9, 13, 12, 8, 14, 11, 15, }, /* Byte 4 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 35: { 5, 4, 0, 2, 7, 3, 6, 1, }, /* Byte 5 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 35: { 5, 4, 0, 2, 7, 3, 6, 1, }, /* Byte 5 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 36: { 15, 9, 11, 13, 10, 14, 8, 12, }, /* Byte 6 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 36: { 15, 9, 11, 13, 10, 14, 8, 12, }, /* Byte 6 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 37: { 7, 3, 0, 4, 2, 5, 1, 6 }, /* Byte 7 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 37: { 7, 3, 0, 4, 2, 5, 1, 6 }, /* Byte 7 */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 44: { 1, 0 , 1, 0 , 0, 1 , 1, 0 }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 44: { 1, 0 , 1, 0 , 0, 1 , 1, 0 }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 44: { 1, 0 , 1, 0 , 0, 1 , 1, 0 }, space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 45: { 1, 0 , 1, 0 , 1, 0 , 1, 0 } space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 45: { 1, 0 , 1, 0 , 1, 0 , 1, 0 } space prohibited before that ',' (ctx:WxW)
https://review.coreboot.org/c/coreboot/+/39848/19/src/mainboard/google/delta... PS19, Line 45: { 1, 0 , 1, 0 , 1, 0 , 1, 0 } space prohibited before that ',' (ctx:WxW)