Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40310 )
Change subject: src/include/device/device.h: Use already defined 'smbios_type11' ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/40310/1/src/include/device/device.h... PS1, Line 143: u8 smbios_slot_type; : u8 smbios_slot_data_width; : u8 smbios_slot_length; These are actually enums from `smbios.h` and that's what the errors with the chip.h removals are about. This should be mentioned in the commit message. That we can drop `struct smbios_type11;` is just a side-effect.