Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48324 )
Change subject: Revert "cbfs: Introduce cbfs_ro_map() and cbfs_ro_load()"
......................................................................
Patch Set 1:
Patch Set 1:
Sorry for the breakage Mike, it looks like you were hit by the same fallout as some other people, which was fixed by CB:48482. The reason only this commit triggered it is that it changes the call from the generic cbfs_locate_file_in_region("COREBOOT") that doesn't go through the mcache to a dedicated API which knows that the COREBOOT region is the normal RO CBFS which has an mcache. This is generally the right thing to do, but if there are problems with the mcache it exposes this code path to it.
Please let me know if you see any more issues with my patch series on your platform.
Yes, this issue was fixed in a fresh coreboot master, so I'm abandoning this "revert".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48324
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0e092c966da60deae21d19eb4053628541595bbb
Gerrit-Change-Number: 48324
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 15 Dec 2020 07:09:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment