Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42505 )
Change subject: libpayload: gdb: Condition video console init on LP_VIDEO_CONSOLE ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... File payloads/libpayload/gdb/stub.c:
https://review.coreboot.org/c/coreboot/+/42505/1/payloads/libpayload/gdb/stu... PS1, Line 76: puts("GDB died, redirecting its last words to the screen:\n");
Done
Unless I'm mistaken, puts/console_write will write to all available output drivers, including video and serial. By putting the puts() and console_write() calls in the conditional, the strings will no longer be printed to the serial console (or any other connected output drivers). Is that okay? (Not even sure if the serial console will be able to output anything if GDB died anyways...)