[coreboot-gerrit] Change in coreboot[master]: soc/intel/skylake: Always use `CHIPSET_LOCKDOWN_COREBOOT`

[Michael Niewöhner (Code Review)]

Attention is currently required from: Nico Huber, Angel Pons, Patrick Rudolph.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52096 )

Change subject: soc/intel/skylake: Always use `CHIPSET_LOCKDOWN_COREBOOT`
......................................................................

Patch Set 1:

(1 comment)

Patchset:

PS1:
> I agree this isn't elegant. However, FSP lockdown is tied into soc/intel/common, so it's not like I can drop it in one patch.

Agreed. We first would need to convert all boards. However, I suspect not everyone will agree here.
> This change is a stopgap to prevent new boards from accidentally using CHIPSET_LOCKDOWN_FSP by omission.

What about adding a checkpatch script for that?
> Another approach would be to invert the enum values for chipset lockdown to make CHIPSET_LOCKDOWN_COREBOOT the default value, but that also requires checking each and every board. I'll see what I can do.

I never understood why that is board-specific anyway. Convert that to Kconfig and make cb lockdown the default? That way people who <3 FSP can keep it if they want to...