Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37591 )
Change subject: mb/google/hatch/variant/hatch: Config MEM_STRAP GPIOs ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG@9 PS1, Line 9: Hatch always used the default MEM_STRAPs in baseboard. That has been intentional.
https://review.coreboot.org/c/coreboot/+/37591/1//COMMIT_MSG@10 PS1, Line 10: in the event that MEM_STRAP is set : differently in the baseboard gpio file That would be a problem in general with any GPIO. I don't understand why MEM_STRAPs would be special. In general, if any GPIO is being touched in baseboard gpio table, its impact will have to be evaluated on all variants.