David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32222 )
Change subject: mb/facebook/watson: Disable turbo
......................................................................
Patch Set 4:
(1 comment)
Patch Set 3:
Also, shouldn’t this be run-time configurable?
Possibly, but we lack a good runtime config UI at present and that is beyond the scope of this patch.
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi...
File src/mainboard/facebook/watson/Kconfig:
https://review.coreboot.org/#/c/32222/2/src/mainboard/facebook/watson/Kconfi...
PS2, Line 45: def_bool n
Ok, maybe I should have asked "Why a Kconfig without prompt?" :) […]
The current deployments use site-local configs. I think adding it to the prompt is overkill in this case, but I don't really have a strong preference so I went ahead and added it (see PS4).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32222
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ief1eaab960c8fdab5bd5041b1a4f0c6ba1dd833f
Gerrit-Change-Number: 32222
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: John Looney
john.looney@gmail.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: insomniac
insomniac@slackware.it
Gerrit-Comment-Date: Mon, 08 Apr 2019 19:21:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment