build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42608 )
Change subject: mb/up/squared: 1/3 Rewrite pad config using intelp2m ......................................................................
Patch Set 5:
(24 comments)
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... File src/mainboard/up/squared/gpio.h:
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 90: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 95: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 100: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_IRQ_ROUTE(SCI) | PAD_RX_POL(INVERT) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 132: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 142: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 147: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 162: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 168: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 174: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 180: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 186: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 191: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 528: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 533: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 538: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 549: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 569: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(RX_DISABLE) | (1 << 1) | 1, line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 575: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 587: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 1013: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 1077: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 1082: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 1141: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), 0), line over 96 characters
https://review.coreboot.org/c/coreboot/+/42608/5/src/mainboard/up/squared/gp... PS5, Line 1234: PAD_FUNC(GPIO) | PAD_RESET(DEEP) | PAD_TRIG(OFF) | PAD_BUF(TX_DISABLE) | (1 << 1), line over 96 characters