Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44375 )
Change subject: libpayload: cbgfx: Add color mapping functionality ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44375/1/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/1/payloads/libpayload/drivers... PS1, Line 95: = { : .alpha = 0, : .rgb.red = 0, : .rgb.green = 0, : .rgb.blue = 0, : };
Should we remove the initialization here to bring it in line with color_map?
Done
https://review.coreboot.org/c/coreboot/+/44375/2/payloads/libpayload/drivers... File payloads/libpayload/drivers/video/graphics.c:
https://review.coreboot.org/c/coreboot/+/44375/2/payloads/libpayload/drivers... PS2, Line 220: fg_color - bg_color
nit: Actually, one more optimization might be to do this calculation in set_color_map() already, so […]
Done