Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31095 )
Change subject: src/soc/intel/cnl/chip.h: Fix preprocessor condition
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/#/c/31095/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31095/2//COMMIT_MSG@10
PS2, Line 10: conditional preprocessor directive, but its condition was incorrect.
Can you please add comment indicating that SOC_INTEL_CANNONLAKE is selected for CNL, CFL and WHL. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31095
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a6959bb615fb5668cbfe54339747d135bd5a005
Gerrit-Change-Number: 31095
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 25 Jan 2019 20:04:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment