Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36764 )
Change subject: src/mainboard/ocp/monolake: Create SMBIOS type 16 for Monolake platform
......................................................................
Patch Set 6:
I'd prefer a common driver for type16 entries. In the last few weeks everybody seem to duplicate those table creation code in mainboard directory.
In the end you only need the maximum slot count, DIMM size per slot, soldered memory size and ECC capability. Those can easily be set in the devicetree.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I821f2c9d6833478d4a6676d93832529295cfb53b
Gerrit-Change-Number: 36764
Gerrit-PatchSet: 6
Gerrit-Owner: Morgan Jang
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jingle Hsu
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 19 Nov 2019 14:40:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment