Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46669 )
Change subject: soc/amd/common/acpi: Create platform.asl to define acpi transitions ......................................................................
Patch Set 1:
(6 comments)
https://review.coreboot.org/c/coreboot/+/46669/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46669/1//COMMIT_MSG@9 PS1, Line 9: Define _WAK, _PTS, and _INI acpi Methods for device. Add detail that it makes callbacks into mainboard methods if provided.
https://review.coreboot.org/c/coreboot/+/46669/1/src/soc/amd/common/acpi/pla... File src/soc/amd/common/acpi/platform.asl:
PS1: License is missing.
/* SPDX-License-Identifier: GPL-2.0-only */
https://review.coreboot.org/c/coreboot/+/46669/1/src/soc/amd/common/acpi/pla... PS1, Line 1: External(_SB.MPTS, MethodObj) : External(_SB.MWAK, MethodObj) : External(_SB.MINI, MethodObj) Can you please add a comment indicating that these are callback methods that a mainboard is expected to implement.
https://review.coreboot.org/c/coreboot/+/46669/1/src/soc/amd/common/acpi/pla... PS1, Line 6: \ I think _INI needs to be under a device. Probably: Scope (_SB) { Method (_INI, ...
https://review.coreboot.org/c/coreboot/+/46669/1/src/soc/amd/common/acpi/pla... PS1, Line 16: { space before {
https://review.coreboot.org/c/coreboot/+/46669/1/src/soc/amd/common/acpi/pla... PS1, Line 25: { space before {