Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40280 )
Change subject: mb/google/volteer: Configure Type C1 Aux pins ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40280/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40280/1//COMMIT_MSG@9 PS1, Line 9: Configure Type C1 Aux pins :
Please remove the space before the colon.
Done
https://review.coreboot.org/c/coreboot/+/40280/1//COMMIT_MSG@10 PS1, Line 10: - GPP_E22(C1_AUXP_DC): GPIO high
Plesae add a space before the (.
Done
https://review.coreboot.org/c/coreboot/+/40280/1//COMMIT_MSG@16 PS1, Line 16: Volteer boots to kernel.
What works now, that didn’t before?
It's part of a larger solution. This portion makes the GPIOs no longer float.
https://review.coreboot.org/c/coreboot/+/40280/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/40280/1/src/mainboard/google/voltee... PS1, Line 242: Retimer FW drives this pin
Can you please add some explanation to commit message why these are being configured this way?
Done