Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/81437?usp=email )
Change subject: lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params ......................................................................
lib/spd_bin: Add LPDDR5X dram_type in use_ddr4_params
For dram_type 21 the switch case in use_ddr4_params function falls to default. This adds SPD_DRAM_LPDDR5X dram_type case to switch case block for dram_type 21 in the function.
With this patch below NOTE will not be observed in the log: [NOTE ] Defaulting to using DDR4 params. Please add dram_type check for 21 to use_ddr4_params
BUG=None BRANCH=None TEST=Boot brox SKU1/SKU2 and verify logs for default case
Change-Id: Id78ef90c0dc2e869c1f0424674b982ba64ba3939 Signed-off-by: Ashish Kumar Mishra ashish.k.mishra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/81437 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Subrata Banik subratabanik@google.com Reviewed-by: Shelley Chen shchen@google.com --- M src/lib/spd_bin.c 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: Shelley Chen: Looks good to me, approved Subrata Banik: Looks good to me, approved build bot (Jenkins): Verified
diff --git a/src/lib/spd_bin.c b/src/lib/spd_bin.c index e005ccb..01f451d 100644 --- a/src/lib/spd_bin.c +++ b/src/lib/spd_bin.c @@ -35,6 +35,7 @@ case SPD_DRAM_DDR4: case SPD_DRAM_DDR5: case SPD_DRAM_LPDDR5: + case SPD_DRAM_LPDDR5X: case SPD_DRAM_LPDDR4: case SPD_DRAM_LPDDR4X: return true;