3 Apr
2023
3 Apr
'23
6:24 p.m.
Attention is currently required from: Raul Rangel, Paul Menzel, Tim Van Patten, Karthik Ramasubramanian, Mark Hasemeyer.
Jon Murphy has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74106 )
Change subject: mb/google/myst: Add ACPI configuration for USB ports ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74106/comment/c81ce13d_b07d48d2 PS5, Line 10: N(some multi-purpose)
Please add a space before the (?
Done
https://review.coreboot.org/c/coreboot/+/74106/comment/71f02d15_8d4eddd2 PS5, Line 12: Update me with list
What updating is this waiting for?
That was a TODO to myself. I'll update the comment. Thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/74106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iecb256cad7b2daea1fddfc8323e88ff5c38d1e51
Gerrit-Change-Number: 74106
Gerrit-PatchSet: 5
Gerrit-Owner: Jon Murphy jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian kramasub@google.com
Gerrit-Reviewer: Mark Hasemeyer markhas@google.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: Tim Van Patten timvp@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Eric Lai eric_lai@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Van Patten timvp@google.com
Gerrit-Attention: Karthik Ramasubramanian kramasub@google.com
Gerrit-Attention: Mark Hasemeyer markhas@google.com
Gerrit-Comment-Date: Mon, 03 Apr 2023 18:24:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Tim Van Patten timvp@google.com
Gerrit-MessageType: comment