Attention is currently required from: V Sowmya, Kedar J. Karanje, Maulik V Vaghela, vagdevi.p@intel.com, Tim Wawrzynczak, Vinay Kumar, Patrick Rudolph. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55706 )
Change subject: soc/intel/alderlake: Set max Pkg C-states to Auto ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/55706/comment/9739b223_7ed2c122 PS6, Line 9: This patch configures max Pkg C-state to Auto which : limits the max C-state to deep C-state fit upto 72col
File src/soc/intel/alderlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/55706/comment/85ae4f50_a0adb34e PS6, Line 47: /* : * The Max Pkg Cstate : * Values 0 - C0/C1, 1 - C2, 2 - C3, 3 - C6, 4 - C7, 5 - C7S, 6 - C8, 7 - C9, 8 - C10, : * 254 - CPU Default , 255 - Auto. : */ : enum pkgcstate_limit { : LIMIT_C0_C1 = 0, : LIMIT_C2 = 1, : LIMIT_C3 = 2, : LIMIT_C6 = 3, : LIMIT_C7 = 4, : LIMIT_C7S = 5, : LIMIT_C8 = 6, : LIMIT_C9 = 7, : LIMIT_C10 = 8, : LIMIT_CPUDEFAULT = 254, : LIMIT_AUTO = 255, : }; can we move this to chip.h ?
https://review.coreboot.org/c/coreboot/+/55706/comment/db7bbb4f_27bddcfa PS6, Line 545: /* Set the Max Pkg C-states to Auto */ do we need this comment? UPD name and assignment is self-explanatory IMHO