Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44075 )
Change subject: mb/ocp/deltalake: Enable PCH thermal sensor via FSP
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44075/2/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/44075/2/src/mainboard/ocp/deltalake...
PS2, Line 53: mupd->FspmConfig.ThermalDeviceEnable = 1;
what is the address of this device (bus/device/function)?
I was thinking of doing something like CB:42557
https://review.coreboot.org/c/coreboot/+/44075/3/src/mainboard/ocp/deltalake...
File src/mainboard/ocp/deltalake/romstage.c:
https://review.coreboot.org/c/coreboot/+/44075/3/src/mainboard/ocp/deltalake...
PS3, Line 15: static const config_t *config = NULL;
Why do we need this global variable? […]
This should not be needed if doing something like CB:42557
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39d0d0a982476f9fece51cfa19dcbd0da5dea690
Gerrit-Change-Number: 44075
Gerrit-PatchSet: 3
Gerrit-Owner: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jingle Hsu
jingle_hsu@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Morgan Jang
Morgan_Jang@wiwynn.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 12:34:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Maxim Polyakov
max.senia.poliak@gmail.com
Comment-In-Reply-To: Johnny Lin
Johnny_Lin@wiwynn.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment