Attention is currently required from: Felix Singer, Ahamed Husni, Tim Wawrzynczak.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67339 )
Change subject: drivers/smbus: smbus console driver ......................................................................
Patch Set 1:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/67339/comment/db1a29cb_e5ed6494 PS1, Line 8: Can you add a description explaining what you are adding and why.
File src/console/Kconfig:
https://review.coreboot.org/c/coreboot/+/67339/comment/6e5823de_dc6252b4 PS1, Line 314: 0x48 This is specific to the hardware you are using. Maybe add a comment in the `help` explaining why this default is used.
https://review.coreboot.org/c/coreboot/+/67339/comment/013e20e1_37dd10e5 PS1, Line 315: CONSOLE_I2C_SMBUS No need for the depends if it's in the `if` block
File src/drivers/smbus/i2c_smbus_console.c:
https://review.coreboot.org/c/coreboot/+/67339/comment/67bcd384_e35807b9 PS1, Line 16: (ENV_BOOTBLOCK || ENV_ROMSTAGE || ENV_RAMSTAGE)) Don't we want console in all stages?
https://review.coreboot.org/c/coreboot/+/67339/comment/1f2933b8_30fe3c15 PS1, Line 17: do_smbus_write_byte(CONFIG_FIXED_SMBUS_IO_BASE, \
Avoid unnecessary line continuations
Please fix.
File src/include/console/i2c_smbus.h:
https://review.coreboot.org/c/coreboot/+/67339/comment/a380a1bc_dd64fc7a PS1, Line 15: newline