Attention is currently required from: Cliff Huang, Julius Werner.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74841 )
Change subject: soc/intel/common/gpio: Add open-drain GPIO macros ......................................................................
Patch Set 2:
(4 comments)
File src/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/74841/comment/0b26c47d_5cb6fde8 PS1, Line 18: void gpio_set_HiZ(gpio_t gpio_num);
I don't really think these belong here in the platform-independent API as separate calls. […]
Ack
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/74841/comment/ebc9b0a4_5378d7a3 PS1, Line 724: ~(PAD_CFG0_TX_STATE & PAD_CFG0_TX_DISABLE),
Since this change ensures that TX_DISBLE is not set when drive TX output, it can be added to gpio_se […]
Ack
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/74841/comment/2f2c09f6_bfa2b2e9 PS1, Line 292: #define PAD_CFG_OD_GPO(pad, rst) \
Since TX is disabled. […]
Done
https://review.coreboot.org/c/coreboot/+/74841/comment/9077382f_105d322c PS1, Line 299: #define PAD_CFG_OD_GPO_LOCK(pad, lock_action) \
Since TX is disabled. […]
Done