[coreboot-gerrit] Change in ...coreboot[master]: sb/intel/common: Show "Add EC firmware" only for boards that need it

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30697 )

Change subject: sb/intel/common: Show "Add EC firmware" only for boards that need it
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/30697/3/src/mainboard/google/hatch/Kconfig 
File src/mainboard/google/hatch/Kconfig:

https://review.coreboot.org/#/c/30697/3/src/mainboard/google/hatch/Kconfig@1... 
PS3, Line 18: MAINBOARD_USES_IFD_EC_REGION
i don't know how you have concluded that hatch will use EC region in IFD?

Can you please check below .fmd file for hatch, do you see EC region. i don't think we are packing anything in EC region for hatch. its a separate binary that we flash differently. its not same as Intel RVP model.

https://github.com/coreboot/coreboot/blob/master/src/mainboard/google/hatch/...