Matt Delco has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33185 )
Change subject: libpayload/i8042/keyboard: Fix return value check for keyboard_cmd
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/33185/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33185/3//COMMIT_MSG@21
PS3, Line 21: anymore.
Could you please clarify, if only the log message was the problem, or if the keyboard also did not w […]
The keyboard was non-functional on the platform I was using. I only noticed the log after tracing back to the code addition and then looked for the msg in the log to get confirmation I was hitting the newly added path.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idcadaae12e0a44e404a1d98c6deb633d97058203
Gerrit-Change-Number: 33185
Gerrit-PatchSet: 4
Gerrit-Owner: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Kepplinger
martink@posteo.de
Gerrit-Reviewer: Matt Delco
delco@chromium.org
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Philip Chen
philipchen@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 04 Jun 2019 14:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment