Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38822 )
Change subject: mb/google/kukui: Add panel for Kakadu ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38822/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38822/3//COMMIT_MSG@14 PS3, Line 14:
Add BRANCH=kukui
Done
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/... File src/mainboard/google/kukui/panel_params/panel-BOE_TV105WUM_NW0.c:
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/... PS3, Line 25: .pixel_clock = 156298, : .lvds_dual_channel = 0, : .refresh = 60, : .ha = 1200, .hbl = 164, .hso = 60, .hspw = 24, : .va = 1920, .vbl = 26, .vso = 14, .vspw = 2,
Regarding these values, do you confirm with panel vendor? Because we need make sure these values are […]
Checking with panel vendor for double confirmation.
https://review.coreboot.org/c/coreboot/+/38822/3/src/mainboard/google/kukui/... PS3, Line 35: INIT_DCS_CMD
Do you confirm the initial code validation with panel Vendor?
Checking with panel vendor for double confirmation.