Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46260 )
Change subject: soc/intel/common: Add PCIe Runtime D3 driver for ACPI
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46260/13/src/soc/intel/common/block...
File src/soc/intel/common/block/pcie/rtd3/rtd3.c:
https://review.coreboot.org/c/coreboot/+/46260/13/src/soc/intel/common/block...
PS13, Line 157: PCIE_PXCS_ADDRESS
Obviously I was not thinking clearly when I did this, it should just be using PCI config space (or a calculated MCFG address) as this value is specific for RP09.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46260
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13e59c996b4f5e4c2657694bda9fad869b64ffde
Gerrit-Change-Number: 46260
Gerrit-PatchSet: 13
Gerrit-Owner: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Sukumar Ghorai
sukumar.ghorai@intel.com
Gerrit-CC: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Thu, 05 Nov 2020 23:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment