Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37094 )
Change subject: Revert "3rdparts/fsp: Update fsp submodule" ......................................................................
Patch Set 2:
Patch Set 2: Okay lets ease down here. I just double checked. What we could to is change this here - and instead of reverting it, just use commit 573bd5d6861376c8b4947d177dfe70592ff80fc2 (which is the renaming one) and use this as the submodule commit for now.
That would keep the rename part of the commit intact, but downgrade a bunch of FSPs, right?
To be honest - I dont think it's my responsibility to debug the FSP now (how could I) - I am just notifying about the error - reverting this and we are go to go again.
It's not your responsibility to debug, right. Doing a proper deep dive into the issue is on Intel (given that they own FSP and do all these secrecy games), but nobody asked you to do that.
It's common courtesy around here to support folks when you see an issue (that may or may not be reproducible for others) by limiting the search space though, and that's what Angel asked for when requesting information that helps reproduce the issue. Since you report the issue, you're the only one that we know has the hardware to do that, hence the request to you. (there's room for improvement on the presentation of that request though, as is with the responses)
A result of such information might be (depending on when the issue was introduced exactly) that we can revert to a commit that keeps other FSPs working while still resetting Cannonlake to a working earlier state.
Right now you're asking to break other chipsets (such as Ice Lake) to fix yours, and people can play that game for a long time with everybody feeling justified about their actions.