Jitao Shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48868 )
Change subject: soc/mediatek: dsi: Fix EoTp flag
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/...
File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/...
PS8, Line 163: if (CONFIG(DRIVER_ANALOGIX_ANX7625))
: mipi_dsi_flags |= MIPI_DSI_MODE_EOT_PACKET;
Yes, you are right. […]
Done
https://review.coreboot.org/c/coreboot/+/48868/8/src/mainboard/google/kukui/...
PS8, Line 170: printk(BIOS_INFO, "%s: dsi_flags=%#x\n", __func__, mipi_dsi_flags);
Yes, this is debug info. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifadd0def13cc264e9d39ab9c981fbdc996396bfa
Gerrit-Change-Number: 48868
Gerrit-PatchSet: 10
Gerrit-Owner: Shaoming Chen
shaoming.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Chen-Tsung Hsieh
chentsung@google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-Reviewer: Nicolas Boichat
drinkcat@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: jitao shi
jitao.shi@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Wentao Qin
qinwentao@huaqin.corp-partner.google.com
Gerrit-CC: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Comment-Date: Wed, 30 Dec 2020 11:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Chen-Tsung Hsieh
chentsung@google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Jitao Shi
jitao.shi@mediatek.corp-partner.google.com
Gerrit-MessageType: comment