Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32280 )
Change subject: mb/google/sarien: Update SMBIOS type17 ......................................................................
Patch Set 2:
(4 comments)
https://review.coreboot.org/#/c/32280/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32280/2//COMMIT_MSG@9 PS2, Line 9: Make SMBIOS type 17 device locator to be match with motherboard : silkscreen Match SMBIOS type 17 device locator with motherboard silkscreen, …
https://review.coreboot.org/#/c/32280/2//COMMIT_MSG@11 PS2, Line 11: Chaneek Channel?
https://review.coreboot.org/#/c/32280/2/src/mainboard/google/sarien/ramstage... File src/mainboard/google/sarien/ramstage.c:
https://review.coreboot.org/#/c/32280/2/src/mainboard/google/sarien/ramstage... PS2, Line 23: silk screen You spell it silkscreen as one word in the commit messages.
https://review.coreboot.org/#/c/32280/2/src/mainboard/google/sarien/ramstage... PS2, Line 30: "DIMM-A"); In Gerrit it looks like it would fit on one line.