[coreboot-gerrit] Change in coreboot[4.11_branch]: mb/lenovo/t60: Fix override devicetrees

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43065 )

Change subject: mb/lenovo/t60: Fix override devicetrees
......................................................................

mb/lenovo/t60: Fix override devicetrees

Commit c1dc2d5e68 (mb/lenovo/t60: Switch to override tree) converted
these boards to override trees, but some device nodes were missed.
Said nodes are essential, as `chip` configuration data is always tied
to device nodes. The resulting `static.c` contained multiple copies
of the `chip` configuration structs, but the wrong ones were hooked up.

The therefore missing configuration of the clockgen led to general
instability, especially with SMP under Linux (probably due to the
attempt to enter lower C states on an idle core). Passing `maxcpus=1`
to the Linux kernel served as a workaround.

Change-Id: I6c26d633d1860cf9a5415994444e75ae1c2e59ad
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43065
Reviewed-by: Arthur Heymans 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/lenovo/t60/variants/t60/overridetree.cb
M src/mainboard/lenovo/t60/variants/z61t/overridetree.cb
2 files changed, 3 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Arthur Heymans: Looks good to me, approved

diff --git a/src/mainboard/lenovo/t60/variants/t60/overridetree.cb b/src/mainboard/lenovo/t60/variants/t60/overridetree.cb
index eee3a4d..551fff3 100644
--- a/src/mainboard/lenovo/t60/variants/t60/overridetree.cb
+++ b/src/mainboard/lenovo/t60/variants/t60/overridetree.cb
@@ -44,6 +44,7 @@
    				register "has_bdc_detection" = "1"
    				register "bdc_gpio_num" = "7"
    				register "bdc_gpio_lvl" = "0"
+					device pnp ff.2 on end
    			end
    			chip superio/nsc/pc87384
    				device pnp 2e.2 off # Serial Port / IR
@@ -62,6 +63,7 @@
    				register "regs" = "{ 0x2e, 0xf7, 0x3c,
    					 0x20, 0x01, 0x00, 0x1b, 0x01,
    					 0x54, 0xff, 0xff, 0x07 }"
+					device i2c 69 on end
    			end
    		end
    	end
diff --git a/src/mainboard/lenovo/t60/variants/z61t/overridetree.cb b/src/mainboard/lenovo/t60/variants/z61t/overridetree.cb
index d29df3b..c372b18 100644
--- a/src/mainboard/lenovo/t60/variants/z61t/overridetree.cb
+++ b/src/mainboard/lenovo/t60/variants/z61t/overridetree.cb
@@ -57,6 +57,7 @@
    				# vendor clockgen setup
    				register "regs" = "{ 0x6d, 0xff, 0xff,
    					0x20, 0x41, 0x7f, 0x18, 0x00 }"
+					device i2c 69 on end
    			end
    		end
    	end