Magf - has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35214 )
Change subject: mb/google/kahlee/treeya: override sku_id() function
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b...
File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/35214/3/src/ec/google/chromeec/ec_b...
PS3, Line 31: uint32_t sku_id(void)
Some boards such as kukui/fizz/gru have themselves' implementation considering with CBI or without CBI (maybe still other factors), put this function here will lead to compile conflicts and wrong output. If wanting to refactor this, need consider all of them. So I still suggest to do this thing in kahlee baseboard for treeya project.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35214
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I631f62021e8104a69a43667a811c9c23e3105596
Gerrit-Change-Number: 35214
Gerrit-PatchSet: 3
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Magf -
magf@bitland.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Sep 2019 01:24:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment