Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46573 )
Change subject: WIP: soc/mediatek/mt8192: add i2c driver support
......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46573/4/src/soc/mediatek/mt8192/i2c...
File src/soc/mediatek/mt8192/i2c.c:
https://review.coreboot.org/c/coreboot/+/46573/4/src/soc/mediatek/mt8192/i2c...
PS4, Line 10: struct
const struct
https://review.coreboot.org/c/coreboot/+/46573/4/src/soc/mediatek/mt8192/i2c...
PS4, Line 152: ARRAY_SIZE(mtk_i2c_bus_controller)
I2C_BUS_NUMBER
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46573
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8ece265687d37bafe2f0de63459ea0fabab8a11
Gerrit-Change-Number: 46573
Gerrit-PatchSet: 4
Gerrit-Owner: yongqiang niu
yongqiang.niu@mediatek.com
Gerrit-Reviewer: Jg Daolongzhu
jg_daolongzhu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 12 Nov 2020 02:52:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment