Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39376 )
Change subject: util/superiotool: Drop one SCH5317 entry
......................................................................
Patch Set 1: Code-Review+2
No strong feelings about this. But it's just working around a bigger
issue: Probing a single byte is not a good idea. We are hit by the
0x85 entry because IT85xx chips are popular atm. But all the other
entries can give false positives, too. IMHO, the probing function
should be adapted, maybe even hidden behind a command line switch.
It's not the first workaround btw., somebody already started to
filter false-positives in probe_idregs_smsc_helper().
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39376
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d1d34d1b88b878461499e52f1a916ee1e33210d
Gerrit-Change-Number: 39376
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 08 Mar 2020 09:36:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment