Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47051 )
Change subject: mb/purism/librem_cnl: Adjust in preparation for new variants ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 35: CONFIG_ nit: CONFIG_ can be omitted iirc
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... File src/mainboard/purism/librem_cnl/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/47051/1/src/mainboard/purism/librem... PS1, Line 4: select SOC_INTEL_WHISKEYLAKE do that in Kconfig, please; have a look at google/hatch how that can be handled nicely 😊