[coreboot-gerrit] Change in coreboot[master]: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset

[Jan Tatje (Code Review)]

Attention is currently required from: Subrata Banik.
Jan Tatje has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )

Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
......................................................................

Patch Set 10:

(1 comment)

Patchset:

PS10:
> Earlier if your platform was entering into earlier if loop and touching bit 7:0 then it was doing wrong programming.

I either don't understand that sentence correctly or it is the opposite, the else clause is what touches bit 7:0.

If ifd_version is set to IFD_VERSION_2 like it was before this change, then it will not touch bits 7:0 and set read and write permissions to true. In the else-clause of the condition, which it uses now, both 7:0 reserved bits are changed and (I think this is what breaks boot) read permission bits 15:8 are set to 0.
> I would say, it was wrong that SKL was considered as IFDv2.

Even if IFDv2 is supposed to mean that 7:0 of the flash master are used for Extended Region Access Permissions somewhere else, in ifdtool it just decides whether FLMSTR uses 31:16 or 31:8 for permissions.

IMHO adding SKLKBL to the ifd_2_platforms list is the easiest solution to fix this issue. This is the change I applied to make it work for me: https://review.coreboot.org/c/coreboot/+/56070