Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45063 )
Change subject: mb/../Kconfig: Correct the maximum number of cpu cores for APL platform
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45063/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/45063/2//COMMIT_MSG@11
PS2, Line 11: maximum number of cores for APL platform is herewith fixed from 8 to 4.
Several boards change from MAX_CPUS=1 to 4? Does that actually fix something on MP init (like impartial MTRR or SMM setup) or are those non-socketed single-core SKUs on reference boards that do not require the change?
The odd case of MAX_CPUS=1 and SMP=Y is a separate issue, should not be hidden by blindly incrementing MAX_CPUS.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45063
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I555ab72520ab9c174b1656c463a5112eb05a236d
Gerrit-Change-Number: 45063
Gerrit-PatchSet: 2
Gerrit-Owner: Mario Scheithauer
mario.scheithauer@siemens.com
Gerrit-Reviewer: Aaron Durbin
adurbin@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 03 Sep 2020 19:25:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment