Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/76512?usp=email )
Change subject: vendorcode/amd/opensil/genoa: Implement console callback
......................................................................
Patch Set 12:
(1 comment)
File src/vendorcode/amd/opensil/genoa_poc/opensil_console.c:
https://review.coreboot.org/c/coreboot/+/76512/comment/bb839c9c_e2e327c3 :
PS10, Line 34: char prefix[60];
: snprintf(prefix, sizeof(prefix), "%s%s:%d:", SilPrefix, (uintptr_t)Function, Line);
Done
printk is the wrong function here; vprintk would have been the correct one. CB:80203 fixes that
--
To view, visit
https://review.coreboot.org/c/coreboot/+/76512?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208eea37ffde64a2311cb9f51e2bcd1ac3dbad4d
Gerrit-Change-Number: 76512
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Varshit Pandya
pandyavarshit@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Comment-Date: Wed, 24 Jan 2024 20:15:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment