Michael Niewöhner has submitted this change. ( https://review.coreboot.org/c/coreboot/+/49060 )
Change subject: mb/clevo/kbl-u: Rework Kconfig ......................................................................
mb/clevo/kbl-u: Rework Kconfig
Rework Kconfig file so that each variant has its own config option with their specific selects / configuration and move common selects to a seperate config option, which is used as base for each variant.
Built clevo/n130wu with BUILD_TIMELESS=1, coreboot.rom remains the same.
Change-Id: I1f07b5851ece6d0943faa9c90fc518805880a27d Signed-off-by: Felix Singer felixsinger@posteo.net Reviewed-on: https://review.coreboot.org/c/coreboot/+/49060 Reviewed-by: Michael Niewöhner foss@mniewoehner.de Reviewed-by: Daniel Maslowski info@orangecms.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/clevo/kbl-u/Kconfig M src/mainboard/clevo/kbl-u/Kconfig.name 2 files changed, 9 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Daniel Maslowski: Looks good to me, but someone else must approve Michael Niewöhner: Looks good to me, approved
diff --git a/src/mainboard/clevo/kbl-u/Kconfig b/src/mainboard/clevo/kbl-u/Kconfig index ed0600a..1229fa4 100644 --- a/src/mainboard/clevo/kbl-u/Kconfig +++ b/src/mainboard/clevo/kbl-u/Kconfig @@ -1,9 +1,7 @@ # SPDX-License-Identifier: GPL-2.0-only
-if BOARD_CLEVO_N130WU - -config BOARD_SPECIFIC_OPTIONS - def_bool y +config BOARD_CLEVO_KBLU_COMMON + def_bool n select BOARD_ROMSIZE_KB_8192 select EC_ACPI select HAVE_ACPI_RESUME @@ -21,6 +19,12 @@ select SPD_READ_BY_WORD select SYSTEM_TYPE_LAPTOP
+config BOARD_CLEVO_N130WU_OPTIONS + bool + select BOARD_CLEVO_KBLU_COMMON + +if BOARD_CLEVO_KBLU_COMMON + config VBOOT select VBOOT_NO_BOARD_SUPPORT select GBB_FLAG_DISABLE_LID_SHUTDOWN diff --git a/src/mainboard/clevo/kbl-u/Kconfig.name b/src/mainboard/clevo/kbl-u/Kconfig.name index 5a6f699c..05a49cd 100644 --- a/src/mainboard/clevo/kbl-u/Kconfig.name +++ b/src/mainboard/clevo/kbl-u/Kconfig.name @@ -4,3 +4,4 @@
config BOARD_CLEVO_N130WU bool "N130WU / N131WU" + select BOARD_CLEVO_N130WU_OPTIONS