EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... File src/mainboard/google/deltaur/sku.c:
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... PS4, Line 11: #include <baseboard/variants.h> nits: add new line here. nits: alphabet order for the includes.
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... PS4, Line 11: #include <gpio.h> same comment as previous one.
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/gpio.c:
https://review.coreboot.org/c/coreboot/+/39868/4/src/mainboard/google/deltau... PS4, Line 11: #include <gpio.h> nit: alphabet order ,thx.